Jason918 opened a new pull request #11517:
URL: https://github.com/apache/pulsar/pull/11517
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the
pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull
request.
Skip *component* if you are unsure about which is the best component.
E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #11412
### Motivation
see #11412
### Modifications
1. Add Method shutdownGracefully for the user case, which will tries its
best to clean up resources and make sure all callbacks is called.
2. Add closed indicating that shutdown is called. If shutdown is called
twice, `ManagedLedgerFactoryClosedException` will be thrown.
3. Fix some test cases which make duplicate shutdown calls to
ManagedLedgerFactory by using both `@Cleanup("shutdown") ` and
`factory.shutdown()`.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change to `shutdown` is already covered by existing tests, such as
org.apache.pulsar.transaction.coordinator.test.MockedBookKeeperTestCase#tearDown.
and
This change added tests and can be verified as follows:
-
`org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryShutdownTest#openEncounteredShutdown`
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
#### For contributor
For this PR, do we need to update docs?
- No, fix some conner case, it does not affect anything to do with normal
users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
