cckellogg commented on a change in pull request #579:
URL: https://github.com/apache/pulsar-client-go/pull/579#discussion_r680090117
##########
File path: pulsar/producer_impl.go
##########
@@ -177,7 +177,14 @@ func (p *producer) internalCreatePartitionsProducers()
error {
if oldProducers != nil {
oldNumPartitions = len(oldProducers)
- if oldNumPartitions == newNumPartitions {
+ if newNumPartitions < oldNumPartitions {
+ p.log.WithFields(log.Fields{
+ "old_partitions": oldNumPartitions,
+ "new_partitions": newNumPartitions,
+ }).Error("Number of partitions shrank, ignored.")
Review comment:
Maybe add a little more context in the message something like this?
`Unexpected response from get partitions the number of partitions decreased`.
By ignoring this do you see any potential issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
