gaoran10 commented on pull request #11490: URL: https://github.com/apache/pulsar/pull/11490#issuecomment-891701237
> We should try to use a magic number with the most significant bit set to 1 because that should be guaranteed to be a non-valid protobuf sequence @merlimat I'm not sure about how to generate a non-valid protobuf sequence. I take a look at some docs, the basic protobuf encode format is `field_number + wire_type + value`, currently, the wire type range is `0-5`, so I use a code `111`. Because I want to use a short value to present the magic number, so the MSB couldn't be 1, could you provide some suggestions? Or we could use a magic number > `111 1111 1111 1111`, an int value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
