zymap commented on a change in pull request #11513:
URL: https://github.com/apache/pulsar/pull/11513#discussion_r682244923
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -305,8 +304,6 @@ public ManagedLedgerImpl(ManagedLedgerFactoryImpl factory,
BookKeeper bookKeeper
this.uninitializedCursors = Maps.newHashMap();
this.clock = config.getClock();
- // Get the next rollover time. Add a random value upto 5% to avoid
rollover multiple ledgers at the same time
- this.maximumRolloverTimeMs = getMaximumRolloverTimeMs(config);
Review comment:
Looks like it will never change since it creates. Shouldn't we change
the place which uses `getMaximumRolloverTimeMs` to the `maximumRolloverTimeMs`
to avoid unnecessary compute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
