BewareMyPower commented on a change in pull request #10309:
URL: https://github.com/apache/pulsar/pull/10309#discussion_r683399213
##########
File path: pulsar-client-cpp/docker-tests.sh
##########
@@ -58,4 +60,26 @@ done
# Start 2 Pulsar standalone instances (one with TLS and one without)
# and execute the tests
-$DOCKER_CMD bash -c "cd /pulsar/pulsar-client-cpp && ./run-unit-tests.sh
${tests}"
+set +e
+DISABLE_COLOR_OUTPUT=""
+if [ "$GTEST_COLOR" = "no" ]; then
+ DISABLE_COLOR_OUTPUT="| cat"
+fi
+$DOCKER_CMD bash -c "cd /pulsar/pulsar-client-cpp && ./run-unit-tests.sh
${tests} $DISABLE_COLOR_OUTPUT"
+RES=$?
+if [ $RES -ne 0 ]; then
Review comment:
This check would never success. The error code returned by `$?` is the
docker container's exit code, not the command's exit code. Even if
`run-unit-tests.sh` exited with a non-zero code, the `RES` would still and
always be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
