cckellogg commented on a change in pull request #588:
URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r685755025
##########
File path: pulsar/internal/connection.go
##########
@@ -764,7 +769,8 @@ func (c *connection) handleSendError(cmdError
*pb.CommandError) {
errMsg := fmt.Sprintf("server error: %s: %s",
cmdError.GetError(), cmdError.GetMessage())
request.callback(nil, errors.New(errMsg))
case pb.ServerError_TopicTerminatedError:
- // TODO: no-op
+ errMsg := fmt.Sprintf("server error: %s: %s",
cmdError.GetError(), cmdError.GetMessage())
+ c.failPendingRequests(errors.New(errMsg))
Review comment:
Is this the correct behavior or should it just remove the pending
request for the requestID. What if there are other pending requests for a
different topic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
