BewareMyPower commented on a change in pull request #11627:
URL: https://github.com/apache/pulsar/pull/11627#discussion_r686023466
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -327,6 +333,14 @@ public boolean isUseTls() {
return false;
}
+ public long getLookupTimeoutMs() {
+ if (lookupTimeoutMs >= 0) {
+ return lookupTimeoutMs;
+ } else {
+ return operationTimeoutMs;
+ }
+ }
Review comment:
It's better to add extra docs to note this behavior since the default
`lookupTimeoutMs` is -1, users may think it means the lookup request never time
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
