cckellogg commented on a change in pull request #590:
URL: https://github.com/apache/pulsar-client-go/pull/590#discussion_r686134560
##########
File path: pulsar/internal/connection.go
##########
@@ -428,7 +428,7 @@ func (c *connection) runPingCheck(pingCheckTicker
*time.Ticker) {
// We have not received a response to the
previous Ping request, the
// connection to broker is stale
c.log.Warn("Detected stale connection to
broker")
- c.Close()
+ c.cnx.Close()
Review comment:
Why is this needed? The c.Close() closes underlying connection already.
Same for the others below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
