michaeljmarshall commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r687238143
########## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/CompactStats.java ########## @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.common.policies.data; Review comment: I hadn't noticed that this file was in a different module than its implementation. I see now that this is following the pattern. Makes sense to me. Thanks for the explanation. ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ########## @@ -1327,7 +1327,11 @@ public Compactor newCompactor() throws PulsarServerException { } public synchronized Compactor getCompactor() throws PulsarServerException { - if (this.compactor == null) { + return getCompactor(true); + } + + public synchronized Compactor getCompactor(boolean initialized) throws PulsarServerException { + if (this.compactor == null && initialized) { Review comment: Nit: I think it might be clearer to name the parameter `shouldInitialize`, but that is just my preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
