This is an automated email from the ASF dual-hosted git repository.

chenhang pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit 3ad526642adc24a8cc67cad85689d8bda3556ee8
Author: Lari Hotari <[email protected]>
AuthorDate: Mon Aug 9 04:11:55 2021 +0300

    [Tests] Fix cpp build not failing when tests fail (#11575)
    
    ### Motivation
    
    - fixes issue that cpp build doesn't fail when tests fail
    - merge after #11557
    
    ### Additional context
    
    - https://github.com/apache/pulsar/pull/11557#issuecomment-893422981
    - https://github.com/apache/pulsar/pull/10309/files#r683626563
    
    ### Modifications
    
    - `set -o pipefail;` is required when using `| cat`
    
    (cherry picked from commit 5ae05544905790791223fc57c242724a9c009fa7)
---
 pulsar-client-cpp/docker-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pulsar-client-cpp/docker-tests.sh 
b/pulsar-client-cpp/docker-tests.sh
index 79a6ded..6d6de2d 100755
--- a/pulsar-client-cpp/docker-tests.sh
+++ b/pulsar-client-cpp/docker-tests.sh
@@ -65,7 +65,7 @@ DISABLE_COLOR_OUTPUT=""
 if [ "$GTEST_COLOR" = "no" ]; then
   DISABLE_COLOR_OUTPUT="| cat"
 fi
-$DOCKER_CMD bash -c "cd /pulsar/pulsar-client-cpp && ./run-unit-tests.sh 
${tests} $DISABLE_COLOR_OUTPUT"
+$DOCKER_CMD bash -c "set -o pipefail; cd /pulsar/pulsar-client-cpp && 
./run-unit-tests.sh ${tests} $DISABLE_COLOR_OUTPUT"
 RES=$?
 if [ $RES -ne 0 ]; then
   (

Reply via email to