BewareMyPower commented on a change in pull request #10961:
URL: https://github.com/apache/pulsar/pull/10961#discussion_r688399701



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1362,7 +1362,7 @@ public ShutdownService getShutdownService() {
 
     protected String brokerUrl(ServiceConfiguration config) {
         if (config.getBrokerServicePort().isPresent()) {
-            return 
brokerUrl(ServiceConfigurationUtils.getAppliedAdvertisedAddress(config),
+            return 
brokerUrl(ServiceConfigurationUtils.getAppliedAdvertisedAddress(config, true),

Review comment:
       No, the default key is the first key of `advertisedListeners`, see 
`validateAndAnalysisAdvertisedListener`. 
https://github.com/apache/pulsar/blob/05827aeb4b0aa4a1b09a7a122f00a65012bf53a1/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/validator/MultipleListenerValidator.java#L73-L75




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to