oversearch commented on a change in pull request #11668:
URL: https://github.com/apache/pulsar/pull/11668#discussion_r689686002
##########
File path: pulsar-client-cpp/CMakeLists.txt
##########
@@ -288,6 +288,10 @@ if (NOT APPLE AND NOT MSVC)
set(CMAKE_CXX_FLAGS_PYTHON "${CMAKE_CXX_FLAGS}")
# Hide all non-exported symbols to avoid conflicts
set(CMAKE_CXX_FLAGS " -fvisibility=hidden -Wl,--exclude-libs,ALL
${CMAKE_CXX_FLAGS}")
+ # Turn on color erro messages and show additional help with errors:
+ set(CMAKE_CXX_FLAGS " -fdiagnostics-show-option -fdiagnostics-color
${CMAKE_CXX_FLAGS}")
Review comment:
Ah yes, good point. I'll find the minimum versions for those and limit
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
