equanz edited a comment on pull request #10534: URL: https://github.com/apache/pulsar/pull/10534#issuecomment-899931286
@Vanlightly > Moreover, it looks to me like the current strategy is already broken seeing as the numbers won't always match (neither numbers nor order) such as when producers come and go. I think so too. Therefore, not only partial producer stats, but also total producer stats will be calculated correctly by this feature. > Is that summary correct? Yes. > Could we not use the producerName for aggregation and use the same strategy of starting a single producer, then making all others inherit their name from the first (when the user doesn't set the name)? We can choose the strategy described above, but I think it will break some existing behavior(currently, internal producer's name aren't same. / if we use the same producerName in the partitioned topic, then they will be aggregated.). If the change described above is approved in the community, I'll change the strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
