Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-902025047
@315157973 @codelipenghui @lhotari I have pushed the change of ensuring all poll() calls go through the pinnedInternalExecutor to avoid threading issues. I didn't have to make an abstract method as I could simply move the pinnedInternalExecutor to ConsumerBase, given that both ConsumerImpl and MultiTopicsConsumerImpl require it. The batch timer in ConsumerBase then simply submits its work to the executor from there. I also moved the failPendingReceive() to the ConsumerBase as it is the same for both. I also renamed the pinnedExecutor to externalPinnedExecutor as that is what it is and make it clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
