gaozhangmin commented on a change in pull request #11683:
URL: https://github.com/apache/pulsar/pull/11683#discussion_r691800578
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3636,6 +3636,21 @@ private PersistentReplicator
getReplicatorReference(String replName, PersistentT
p -> new PartitionedTopicMetadata(numPartitions));
updatePartition.complete(null);
} catch (Exception e) {
+ getPartitionedTopicMetadataAsync(topicName, false,
false).thenAccept(metadata -> {
+ int oldPartition = metadata.partitions;
+ for (int i = oldPartition; i < numPartitions; i++) {
+ String managedLedgerPath =
ZkAdminPaths.managedLedgerPath(topicName.getPartition(i));
+ namespaceResources().getPartitionedTopicResources()
+
.deleteAsync(managedLedgerPath).exceptionally(ex1 -> {
+ log.error("[{}] Failed to delete managedLedger
znode {}", clientAppId(),
+ managedLedgerPath, ex1.getCause());
+ return null;
+ });
+ }
+ }).exceptionally(ex -> {
+ updatePartition.completeExceptionally(e);
Review comment:
Should I delete `exceptionally` ? since it do nothing in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]