cckellogg commented on a change in pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#discussion_r694208442
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupPublishLimiter.java
##########
@@ -160,12 +168,22 @@ private void replaceLimiters(Runnable updater) {
@Override
public void close() {
- this.apply();
- replaceLimiters(null);
+ replaceLimiters(null);
Review comment:
Does the order of calls matter here? If so maybe add a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
