oversearch commented on a change in pull request #11668:
URL: https://github.com/apache/pulsar/pull/11668#discussion_r695159041
##########
File path: pulsar-client-cpp/lib/LogUtils.h
##########
@@ -35,7 +35,7 @@ namespace pulsar {
#endif
#define DECLARE_LOG_OBJECT()
\
- static pulsar::Logger* logger() {
\
+ inline pulsar::Logger* logger() {
\
Review comment:
@BewareMyPower ahh sorry about that! You're quite right - I didn't
notice the filenames acting screwy when I was testing this. GCC was
complaining about unused functions in several translation units with this
marked "static". I assumed it was something wrong with this definition, but I
should have checked them all individually, since it's simply
`DECLARE_LOG_OBJECT()` lines that are never actually used.
If you want I can fix this in a separate PR. I'm planning to get another
change together anyway for turning on `-WExtra`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
