michaeljmarshall commented on a change in pull request #11113:
URL: https://github.com/apache/pulsar/pull/11113#discussion_r697542442
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
##########
@@ -120,7 +120,7 @@ public void initialize(ServiceConfiguration conf,
ConfigurationCacheService conf
// list is empty)
Review comment:
It appears that the original intent of this code was to consider an
empty list as a special case that had special logic. I don't have enough
context to know why, but it might be worth reviewing
https://github.com/apache/pulsar/pull/2981, where this code was first
introduced. If I had to guess, it's because it doesn't make much sense to have
a subscription that cannot be consumed.
If this change is accepted, the comment on this line and the one above need
to be updated:
https://github.com/apache/pulsar/blob/879ab3a174b6cc78c15199f8c6fe6aefb1959116/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java#L119-L120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
