kaushik-develop opened a new pull request #11821:
URL: https://github.com/apache/pulsar/pull/11821
- fix updateLocalQuota to not attempt Dispatch changes
- add checks for totalUsed of 0, and unconfigured RG in
ResourceQuotaCalculatorImpl
- UT for above
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the
pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull
request.
Skip *component* if you are unsure about which is the best component.
E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Bug fixes in RG rate limiting
*Explain here the context, and why you're making that change. What is the
problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
- don't clobber the publish rate limiter with (yet-unsupported) Dispatch
side values
- add checks against unconfigured RG rate-limiter component(s) and
total-usage of zero
### Verifying this change
- [X] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is already covered by existing tests, such as *(please describe
tests)*.
- mvn test
-Dtest=org.apache.pulsar.broker.resourcegroup.ResourceGroupRateLimiterTest -pl
pulsar-broker
- mvn test
-Dtest=org.apache.pulsar.broker.resourcegroup.ResourceGroupServiceTest -pl
pulsar-broker
- mvn test
-Dtest=org.apache.pulsar.broker.resourcegroup.ResourceQuotaCalculatorImplTest
-pl pulsar-broker
### Does this pull request potentially affect one of the following parts: no
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
#### For contributor
For this PR, do we need to update docs? No.
- If yes, please update docs or create a follow-up issue if you need help.
- If no, please explain why.
#### For committer
For this PR, do we need to update docs?
- If yes,
- if you update docs in this PR, label this PR with the `doc` label.
- if you plan to update docs later, label this PR with the `doc-required`
label.
- if you need help on updating docs, create a follow-up issue with the
`doc-required` label.
- If no, label this PR with the `no-need-doc` label and explain why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
