eolivelli commented on a change in pull request #11794:
URL: https://github.com/apache/pulsar/pull/11794#discussion_r698505866
##########
File path: pulsar-broker-common/pom.xml
##########
@@ -65,6 +65,25 @@
<artifactId>jjwt-impl</artifactId>
</dependency>
+ <dependency>
Review comment:
is it really necessary to add all of these third party deps ?
I wonder if it won't be better to create a separate module and let users
drop the jar in pulsar/lib
if we want to go this way we have to verify all the licenses/NOTICE files
and list the artifacts in
https://github.com/apache/pulsar/tree/master/distribution/server/src/assemble
and probably in
https://github.com/apache/pulsar/tree/master/distribution/server/licenses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
