gaoran10 commented on a change in pull request #11813:
URL: https://github.com/apache/pulsar/pull/11813#discussion_r700140082



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -762,6 +764,9 @@ public void asyncReadEntriesOrWait(int maxEntries, long 
maxSizeBytes, ReadEntrie
         } else {
             OpReadEntry op = OpReadEntry.create(this, readPosition, 
numberOfEntriesToRead, callback,
                     ctx, maxPosition);
+            if (op.readPosition == null) {
+                return;

Review comment:
       Maybe we need to call the method `callback.readEntriesFailed` to make 
sure the caller gets a result.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to