eolivelli commented on a change in pull request #11852:
URL: https://github.com/apache/pulsar/pull/11852#discussion_r700763721
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -2300,6 +2300,13 @@ protected void internalGetMessageById(AsyncResponse
asyncResponse, long ledgerId
}
PersistentTopic topic = (PersistentTopic)
getTopicReference(topicName);
ManagedLedgerImpl ledger = (ManagedLedgerImpl)
topic.getManagedLedger();
+ if (null == ledger.getLedgerInfo(ledgerId).get()) {
+ log.error("[{}] Failed to get message with ledgerId {} entryId
{} from {}, "
+ + "the ledgerId does not belong to this
topic.",
+ clientAppId(), ledgerId, entryId, topicName);
+ asyncResponse.resume(new RestException(Status.NOT_FOUND,
+ "Message not found, the ledgerId does not belong to
this topic"));
Review comment:
We should add a 'return' here
Let me send a fix up patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
