kaushik-develop commented on a change in pull request #11916:
URL: https://github.com/apache/pulsar/pull/11916#discussion_r702055889
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java
##########
@@ -341,7 +341,11 @@ protected BytesAndMessagesCount
updateLocalQuota(ResourceGroupMonitoringClass mo
oldBMCount = monEntity.quotaForNextPeriod;
try {
monEntity.quotaForNextPeriod = newQuota;
- this.resourceGroupPublishLimiter.update(newQuota);
+ if (monClass == ResourceGroupMonitoringClass.Publish) {
+ this.resourceGroupPublishLimiter.update(newQuota);
+ } else {
Review comment:
Since we are early-quitting for anything except Publish (see line 329),
I didn't see why this check for non-Publish is required again in line 346.
Small nit: in earlier code review, someone asked me to change the comparison
to Publish.equals (instead of the direct "==" check). JFYI, in case this check
here needs to remain for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
