eolivelli commented on a change in pull request #11893:
URL: https://github.com/apache/pulsar/pull/11893#discussion_r703013367
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3069,23 +3069,29 @@ protected void
internalTerminatePartitionedTopic(AsyncResponse asyncResponse, bo
validateTopicOwnership(topicName, authoritative);
validateTopicOperation(topicName, TopicOperation.TERMINATE);
- List<MessageId> messageIds = new ArrayList<>();
+ Map<Integer, MessageId> messageIds = new HashMap<>();
Review comment:
This mapping is accessed by multiple threads.
It should be a synchonized map or ConcurrentHashMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
