tuteng commented on a change in pull request #11931:
URL: https://github.com/apache/pulsar/pull/11931#discussion_r704122834



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/protocol/TokenClient.java
##########
@@ -76,6 +77,9 @@ public TokenResult 
exchangeClientCredentials(ClientCredentialsExchangeRequest re
         bodyMap.put("client_id", req.getClientId());
         bodyMap.put("client_secret", req.getClientSecret());
         bodyMap.put("audience", req.getAudience());

Review comment:
       I haven't seen the audience related specification yet, if I want to 
change this configuration, there might be other parts that need to be updated, 
for example 
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/FlowBase.java#L61,
 maybe other needs need to be updated as well, I'm worried about breaking 
client compatibility, I want to fixed it in the next pr




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to