shibd removed a comment on pull request #11998:
URL: https://github.com/apache/pulsar/pull/11998#issuecomment-917663949


   > Looks good, can we add/update existing unit test to verify it? Probably at 
here: 
https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
   
   @MarvinCai  Thank you reply. This PR Maybe it's not right, It will change 
the original design. I noticed `addAndGetUnAckedMsgs` method  is only call  
when the `isIndividualAckMode(subscribe model eq Shared / Key_Shared)`.
   
   Do you know why it's designed like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to