EronWright opened a new pull request #12072:
URL: https://github.com/apache/pulsar/pull/12072


   
   Master Issue: #12040
   
   ### Motivation
   
   This PR introduces an optional HTTP header `X-Pulsar-ListenerName` to the 
`TopicLookup` operation of the Pulsar Admin API.  The header supplies the 
listener name to use when the broker has multiple advertised listeners.  Today 
the `TopicLookup` operation accepts a query parameter `listenerName` for that 
same purpose.
   
   The motivation for adding a header-based alternative is to improve support 
smart listener selection via HTTP gateways or proxies that are capable of 
rewriting headers (see: [Istio virtual 
services](https://istio.io/latest/docs/reference/config/networking/virtual-service/#Headers)).
   
   See #12040 for more background.
   
   ### Modifications
   
   - Modify `TopicLookup` operation to use a header (query string takes 
precedence).
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: yes
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [ ] doc 
     
     (javadocs)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to