liangyepianzhou commented on a change in pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#discussion_r711583469



##########
File path: 
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##########
@@ -406,11 +487,23 @@ public static void main(String[] args) throws Exception {
             long total = totalMessagesReceived.sum();
             double rate = messagesReceived.sumThenReset() / elapsed;
             double throughput = bytesReceived.sumThenReset() / elapsed * 8 / 
1024 / 1024;
-
+            double rateAck = messageAck.sumThenReset() / elapsed;
+            long totalTransaction = 0;
+            double averageTimePerTransaction = 0;
+            if (arguments.isEnableTransaction) {
+                totalTransaction = totalNumTransaction.sum();
+                averageTimePerTransaction = elapsed / 
numTransaction.sumThenReset();
+            }
             reportHistogram = recorder.getIntervalHistogram(reportHistogram);
 
+            String transactionLog = arguments.isEnableTransaction ? 
"---transaction: " + totalTransaction +

Review comment:
       It is very enlightening. Printing the total number in each log is more 
helpful for users to grasp the overall situation, instead of waiting for the 
end of each time to know the overall situation of the performance test. In 
fact, as long as there is no conflict, we should put more information on it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to