EronWright commented on a change in pull request #12056:
URL: https://github.com/apache/pulsar/pull/12056#discussion_r711640416



##########
File path: 
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -121,13 +121,18 @@
     private String configurationStoreServers;
     @FieldContext(
         category = CATEGORY_SERVER,
-        doc = "The port for serving binary protobuf requests"
+        doc = "The port for serving binary protobuf requests."
+            + "If set, defines a server binding for 
bindAddress:brokerServicePort"
+            + "without an associated advertised listener."

Review comment:
       Yes.  There is no strong association for `brokerServicePort` to a 
specific listener, and so the current behavior  is in effect.  The current 
behavior is that lookups use the internal listener unless the lookup request 
contains a `listenerName` parameter.  Of course, the `listenerName` parameter 
is supported by the new bindings too, but they have a better default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to