BewareMyPower commented on issue #12087: URL: https://github.com/apache/pulsar/issues/12087#issuecomment-922449420
@eolivelli > Otherwise we risk to fail to support compatibility for future versions. I don't understand well for the compatibility issue. The interface is a part of **pulsar-common** package. If there're no compatibility changes for `BrokerEntryMetadata` and `MessageMetadata`, it should be stable. ---- Actually there's a similar API. When creating a producer, we can configure a `BatcherBuilder` interface. https://github.com/apache/pulsar/blob/fccc1cf60467bc0600c6507271cff85146d9f9e8/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/BatcherBuilder.java#L56-L60 However, this `build` method is meaningless. The actual type is `BatchMessageContainer`. However, the actual required type is `BatchMessageContainerBase`. https://github.com/apache/pulsar/blob/fccc1cf60467bc0600c6507271cff85146d9f9e8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L235-L236 `BatchMessageContainerBase` needs to depend `OpSendMsg`, `ProducerImpl`, etc. So it cannot be a part of **pulsar-client-api** package. `BaseMessageContainer` is just a fake interface. We can also take the similar way for `PayloadConverter` but it's not better than loading class at runtime IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
