eolivelli commented on pull request #12097:
URL: https://github.com/apache/pulsar/pull/12097#issuecomment-922650048


   > I believe the test set the DNS resolver manually
   Which test ?
   
   My idea is to add an integration test that reproduces the behaviour of a sys 
admin that configures this feature.
   It should be easy to see the error in the logs of the test.
   
   It looks like we do not have such kind of integration tests.
   
   @addisonj do you think it is worth do add it ?
   
   btw please answer to my comment about the null check, and I am happy with 
this patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to