dlg99 commented on pull request #12101: URL: https://github.com/apache/pulsar/pull/12101#issuecomment-923346309
> This will not fix the root cause of the other issue, as it there's not a way to precisely prevent requests while disconnected (eg: we could get disconnected while the request was already issued). @merlimat I do agree with this assessment. Do we really need to prevent requests when disconnected? I think we can split managed ledger trim into two phases: 1. update metadata to include active BK ledgers (what we have now) + list of BK ledgers to delete. Do it as a single metadata update, in one transaction. 2. process list of BK ledgers to delete, actually delete the ledgers (skip if they were deleted already), possibly update metadata (or defer the update until next trim or managed ledger init) I think this will prevent managed ledger from getting metadata out of sync with the data as result of trim/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
