michaeljmarshall opened a new pull request #12119: URL: https://github.com/apache/pulsar/pull/12119
### Motivation As discussed on the [dev](https://lists.apache.org/x/thread.html/rc8b796dda2bc1b022e855c7368d832b570967cb1ef29e9cd18e04e97@%3Cdev.pulsar.apache.org%3E) and [users](https://lists.apache.org/x/thread.html/rc30a4699a1040e6613adbd3eced218f838844ff7f5ef9713ee11be96@%3Cusers.pulsar.apache.org%3E) mailing lists, the Pulsar Discovery Service no longer appears necessary. As further justification, when inspecting maven central, the discovery service jar is only a dependency for other Pulsar modules, which only use the discovery service for tests. https://mvnrepository.com/artifact/org.apache.pulsar/pulsar-discovery-service/usages This PR removes the Pulsar Discovery Service. It leaves old references to the discovery service in the versioned docs, as the discovery service is still available for those versions of Pulsar. ### Modifications * Remove `pulsar-discovery-service` module * Remove discovery references from `bin/pulsar` * Remove discovery references from `bin/pulsar-daemon` * Remove `conf/discovery.conf` file * Remove all references to `pulsar-discovery-service` module from `pom.xml` files * Remove discovery service tests from the `pulsar-broker` module (only removed tests for the discovery service module) * Update docs ### Verifying this change I built the project and will ensure tests pass. The one concern might be that I've deleted too many tests. I only deleted tests with explicit references to the removed module. It'd be worth a second check from someone else, too. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: yes I've described the changes above. We're removing a module, so it will break certain parts of our API. The module appears unused, and we've taken steps to discuss this on the mailing list to ensure there is proper discussion and notice. ### Documentation I've updated the docs by removing references to the discovery service. It'd be a good idea to make sure this gets mentioned in the change log when we release the major version that includes this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
