michaeljmarshall commented on a change in pull request #12120:
URL: https://github.com/apache/pulsar/pull/12120#discussion_r713569623
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -65,6 +67,9 @@
private final AsyncLoadingCache<String, Boolean> existsCache;
private final CopyOnWriteArrayList<MetadataCacheImpl<?>> metadataCaches =
new CopyOnWriteArrayList<>();
+ @Getter
+ private boolean isConnected = true;
Review comment:
Should this have the `volatile` keyword? It seems like it will be
written to from the `ZKSessionWatcher` thread and then read from the cache's
threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
