Huanli-Meng commented on a change in pull request #12099:
URL: https://github.com/apache/pulsar/pull/12099#discussion_r713919606
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -4,7 +4,7 @@ title: Pulsar Java client
sidebar_label: Java
---
-You can use Pulsar Java client to create Java [producer](#producer),
[consumer](#consumer), and [readers](#reader-interface) of messages and to
perform [administrative tasks](admin-api-overview.md). The current version of
the Java client is **{{pulsar:version}}**.
+You can use Pulsar Java client to create Java [producer](#producer),
[consumer](#consumer), and [readers](#reader) of messages and to perform
[administrative tasks](admin-api-overview.md). The current version of the Java
client is **{{pulsar:version}}**.
Review comment:
```suggestion
You can use a Pulsar Java client to create the Java [producer](#producer),
[consumer](#consumer), and [readers](#reader) of messages and to perform
[administrative tasks](admin-api-overview.md). The current Java client version
is **{{pulsar:version}}**.
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -101,34 +100,35 @@ PulsarClient client = PulsarClient.builder()
If you create a client, you can use the `loadConf` configuration. The
following parameters are available in `loadConf`.
-| Type | Name | <div style="width:260px">Description</div> | Default
+| Name | Type | <div style="width:260px">Description</div> | Default
|---|---|---|---
-String | `serviceUrl` |Service URL provider for Pulsar service | None
-String | `authPluginClassName` | Name of the authentication plugin | None
-String | `authParams` | String represents parameters for the authentication
plugin <br/><br/>**Example**<br/> key1:val1,key2:val2|None
-long|`operationTimeoutMs`|Operation timeout |30000
-long|`statsIntervalSeconds`|Interval between each stats info<br/><br/>Stats is
activated with positive `statsInterval`<br/><br/>Set `statsIntervalSeconds` to
1 second at least |60
-int|`numIoThreads`| The number of threads used for handling connections to
brokers | 1
-int|`numListenerThreads`|The number of threads used for handling message
listeners. The listener thread pool is shared across all the consumers and
readers using the "listener" model to get messages. For a given consumer, the
listener is always invoked from the same thread to ensure ordering. If you want
multiple threads to process a single topic, you need to create a
[`shared`](https://pulsar.apache.org/docs/en/next/concepts-messaging/#shared)
subscription and multiple consumers for this subscription. This does not ensure
ordering.| 1
-boolean|`useTcpNoDelay`|Whether to use TCP no-delay flag on the connection to
disable Nagle algorithm |true
-boolean |`useTls` |Whether to use TLS encryption on the connection| false
-string | `tlsTrustCertsFilePath` |Path to the trusted TLS certificate file|None
-boolean|`tlsAllowInsecureConnection`|Whether the Pulsar client accepts
untrusted TLS certificate from broker | false
-boolean | `tlsHostnameVerificationEnable` | Whether to enable TLS hostname
verification|false
-int|`concurrentLookupRequest`|The number of concurrent lookup requests allowed
to send on each broker connection to prevent overload on broker|5000
-int|`maxLookupRequest`|The maximum number of lookup requests allowed on each
broker connection to prevent overload on broker | 50000
-int|`maxNumberOfRejectedRequestPerConnection`|The maximum number of rejected
requests of a broker in a certain time frame (30 seconds) after the current
connection is closed and the client creates a new connection to connect to a
different broker|50
-int|`keepAliveIntervalSeconds`|Seconds of keeping alive interval for each
client broker connection|30
-int|`connectionTimeoutMs`|Duration of waiting for a connection to a broker to
be established <br/><br/>If the duration passes without a response from a
broker, the connection attempt is dropped|10000
-int|`requestTimeoutMs`|Maximum duration for completing a request |60000
-int|`defaultBackoffIntervalNanos`| Default duration for a backoff interval |
TimeUnit.MILLISECONDS.toNanos(100);
-long|`maxBackoffIntervalNanos`|Maximum duration for a backoff
interval|TimeUnit.SECONDS.toNanos(30)
-SocketAddress|`socks5ProxyAddress`|SOCKS5 proxy address | None
-String|`socks5ProxyUsername`|SOCKS5 proxy username | None
-String|`socks5ProxyPassword`|SOCKS5 proxy password | None
+`serviceUrl` | String | Service URL provider for Pulsar service | None
+`authPluginClassName` | String | Name of the authentication plugin | None
+ `authParams` | String | String represents parameters for the authentication
plugin <br/><br/>**Example**<br/> key1:val1,key2:val2|None
Review comment:
```suggestion
`authParams` | String | Parameters for the authentication plugin
<br/><br/>**Example**<br/> key1:val1,key2:val2|None
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -171,25 +171,25 @@ stringProducer.send("My message");
### Configure producer
-If you instantiate a `Producer` object by specifying only a topic name as the
example above, use the default configuration for producer.
+If you instantiate a `Producer` object by specifying only a topic name as the
example above, the default configuration of producer is used..
Review comment:
```suggestion
If you instantiate a `Producer` object by specifying only a topic name as
the example above, the default configuration of producer is used.
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -101,34 +100,35 @@ PulsarClient client = PulsarClient.builder()
If you create a client, you can use the `loadConf` configuration. The
following parameters are available in `loadConf`.
-| Type | Name | <div style="width:260px">Description</div> | Default
+| Name | Type | <div style="width:260px">Description</div> | Default
|---|---|---|---
-String | `serviceUrl` |Service URL provider for Pulsar service | None
-String | `authPluginClassName` | Name of the authentication plugin | None
-String | `authParams` | String represents parameters for the authentication
plugin <br/><br/>**Example**<br/> key1:val1,key2:val2|None
-long|`operationTimeoutMs`|Operation timeout |30000
-long|`statsIntervalSeconds`|Interval between each stats info<br/><br/>Stats is
activated with positive `statsInterval`<br/><br/>Set `statsIntervalSeconds` to
1 second at least |60
-int|`numIoThreads`| The number of threads used for handling connections to
brokers | 1
-int|`numListenerThreads`|The number of threads used for handling message
listeners. The listener thread pool is shared across all the consumers and
readers using the "listener" model to get messages. For a given consumer, the
listener is always invoked from the same thread to ensure ordering. If you want
multiple threads to process a single topic, you need to create a
[`shared`](https://pulsar.apache.org/docs/en/next/concepts-messaging/#shared)
subscription and multiple consumers for this subscription. This does not ensure
ordering.| 1
-boolean|`useTcpNoDelay`|Whether to use TCP no-delay flag on the connection to
disable Nagle algorithm |true
-boolean |`useTls` |Whether to use TLS encryption on the connection| false
-string | `tlsTrustCertsFilePath` |Path to the trusted TLS certificate file|None
-boolean|`tlsAllowInsecureConnection`|Whether the Pulsar client accepts
untrusted TLS certificate from broker | false
-boolean | `tlsHostnameVerificationEnable` | Whether to enable TLS hostname
verification|false
-int|`concurrentLookupRequest`|The number of concurrent lookup requests allowed
to send on each broker connection to prevent overload on broker|5000
-int|`maxLookupRequest`|The maximum number of lookup requests allowed on each
broker connection to prevent overload on broker | 50000
-int|`maxNumberOfRejectedRequestPerConnection`|The maximum number of rejected
requests of a broker in a certain time frame (30 seconds) after the current
connection is closed and the client creates a new connection to connect to a
different broker|50
-int|`keepAliveIntervalSeconds`|Seconds of keeping alive interval for each
client broker connection|30
-int|`connectionTimeoutMs`|Duration of waiting for a connection to a broker to
be established <br/><br/>If the duration passes without a response from a
broker, the connection attempt is dropped|10000
-int|`requestTimeoutMs`|Maximum duration for completing a request |60000
-int|`defaultBackoffIntervalNanos`| Default duration for a backoff interval |
TimeUnit.MILLISECONDS.toNanos(100);
-long|`maxBackoffIntervalNanos`|Maximum duration for a backoff
interval|TimeUnit.SECONDS.toNanos(30)
-SocketAddress|`socks5ProxyAddress`|SOCKS5 proxy address | None
-String|`socks5ProxyUsername`|SOCKS5 proxy username | None
-String|`socks5ProxyPassword`|SOCKS5 proxy password | None
+`serviceUrl` | String | Service URL provider for Pulsar service | None
+`authPluginClassName` | String | Name of the authentication plugin | None
+ `authParams` | String | String represents parameters for the authentication
plugin <br/><br/>**Example**<br/> key1:val1,key2:val2|None
+`operationTimeoutMs`|long|`operationTimeoutMs`|Operation timeout |30000
+`statsIntervalSeconds`|long|Interval between each stats info<br/><br/>Stats is
activated with positive `statsInterval`<br/><br/>Set `statsIntervalSeconds` to
1 second at least |60
Review comment:
```suggestion
`statsIntervalSeconds`|long|Interval between each stats
information<br/><br/>Stats is activated with positive
`statsInterval`<br/><br/>Set `statsIntervalSeconds` to 1 second at least. |60
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -14,8 +14,7 @@ Package | Description | Maven Artifact
:-------|:------------|:--------------
[`org.apache.pulsar.client.api`](/api/client) | The producer and consumer API
|
[org.apache.pulsar:pulsar-client:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client%7C{{pulsar:version}}%7Cjar)
[`org.apache.pulsar.client.admin`](/api/admin) | The Java [admin
API](admin-api-overview.md) |
[org.apache.pulsar:pulsar-client-admin:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-admin%7C{{pulsar:version}}%7Cjar)
-`org.apache.pulsar.client.all` |Includes both `pulsar-client` and
`pulsar-client-admin`<br></br> Both `pulsar-client` and `pulsar-client-admin`
are shaded packages and they shade dependencies independently. Consequently,
the applications using both `pulsar-client` and `pulsar-client-admin` have
redundant shaded classes. It would be troublesome if you introduce new
dependencies but forget to update shading rules. <br></br> In this case, you
can use `pulsar-client-all`, which shades dependencies only one time and
reduces the size of dependencies.
|[org.apache.pulsar:pulsar-client-all:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-all%7C{{pulsar:version}}%7Cjar)
-
+`org.apache.pulsar.client.all` |Includes both `pulsar-client` and
`pulsar-client-admin`<br/> Both `pulsar-client` and `pulsar-client-admin` are
shaded packages and they shade dependencies independently. Consequently, the
applications using both `pulsar-client` and `pulsar-client-admin` have
redundant shaded classes. It would be troublesome if you introduce new
dependencies but forget to update shading rules. <br/> In this case, you can
use `pulsar-client-all`, which shades dependencies only one time and reduces
the size of dependencies.
|[org.apache.pulsar:pulsar-client-all:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-all%7C{{pulsar:version}}%7Cjar)
Review comment:
```suggestion
`org.apache.pulsar.client.all` |Include both `pulsar-client` and
`pulsar-client-admin`.<br/> Both `pulsar-client` and `pulsar-client-admin` are
shaded packages and they shade dependencies independently. Consequently, the
applications using both `pulsar-client` and `pulsar-client-admin` have
redundant shaded classes. It would be troublesome if you introduce new
dependencies but forget to update shading rules. <br/> In this case, you can
use `pulsar-client-all`, which shades dependencies only one time and reduces
the size of dependencies.
|[org.apache.pulsar:pulsar-client-all:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-all%7C{{pulsar:version}}%7Cjar)
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -624,7 +624,7 @@ Consumer consumer2 = client.newConsumer()
//Both consumer1 and consumer2 are active consumers.
```
-`Key_Shared` subscription is like `Shared` subscription, all consumers can
attach to the same subscription. But it is different from `Key_Shared`
subscription, messages with the same key are delivered to only one consumer in
order. The possible distribution of messages between different consumers (by
default we do not know in advance which keys will be assigned to a consumer,
but a key will only be assigned to a consumer at the same time).
+`Key_Shared` subscription is like `Shared` subscription, all consumers can
attach to the same subscription. But it is different from `Shared`
subscription, messages with the same key are delivered to only one consumer in
order. The possible distribution of messages between different consumers (by
default we do not know in advance which keys will be assigned to a consumer,
but a key will only be assigned to a consumer at the same time).
Review comment:
```suggestion
Just like in the `Shared` subscription, all consumers in the `Key_Shared`
subscription mode can attach to the same subscription. But the `Key_Shared`
subscription mode is different from the `Shared` subscription. In the
`Key_Shared` subscription mode, messages with the same key are delivered to
only one consumer in order. The possible distribution of messages between
different consumers (by default we do not know in advance which keys will be
assigned to a consumer, but a key will only be assigned to a consumer at the
same time).
```
##########
File path: site2/docs/client-libraries-java.md
##########
@@ -14,8 +14,7 @@ Package | Description | Maven Artifact
:-------|:------------|:--------------
[`org.apache.pulsar.client.api`](/api/client) | The producer and consumer API
|
[org.apache.pulsar:pulsar-client:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client%7C{{pulsar:version}}%7Cjar)
[`org.apache.pulsar.client.admin`](/api/admin) | The Java [admin
API](admin-api-overview.md) |
[org.apache.pulsar:pulsar-client-admin:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-admin%7C{{pulsar:version}}%7Cjar)
-`org.apache.pulsar.client.all` |Includes both `pulsar-client` and
`pulsar-client-admin`<br></br> Both `pulsar-client` and `pulsar-client-admin`
are shaded packages and they shade dependencies independently. Consequently,
the applications using both `pulsar-client` and `pulsar-client-admin` have
redundant shaded classes. It would be troublesome if you introduce new
dependencies but forget to update shading rules. <br></br> In this case, you
can use `pulsar-client-all`, which shades dependencies only one time and
reduces the size of dependencies.
|[org.apache.pulsar:pulsar-client-all:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-all%7C{{pulsar:version}}%7Cjar)
-
+`org.apache.pulsar.client.all` |Includes both `pulsar-client` and
`pulsar-client-admin`<br/> Both `pulsar-client` and `pulsar-client-admin` are
shaded packages and they shade dependencies independently. Consequently, the
applications using both `pulsar-client` and `pulsar-client-admin` have
redundant shaded classes. It would be troublesome if you introduce new
dependencies but forget to update shading rules. <br/> In this case, you can
use `pulsar-client-all`, which shades dependencies only one time and reduces
the size of dependencies.
|[org.apache.pulsar:pulsar-client-all:{{pulsar:version}}](http://search.maven.org/#artifactdetails%7Corg.apache.pulsar%7Cpulsar-client-all%7C{{pulsar:version}}%7Cjar)
Review comment:
one more comment, please conform with @Anonymitaet whether <br/> is a
correct. I think we should use <br />.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
