eolivelli commented on a change in pull request #12146:
URL: https://github.com/apache/pulsar/pull/12146#discussion_r714740551
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -834,6 +822,15 @@ private void addWebServerHandlers(WebService webService,
addBrokerAdditionalServlets(webService, attributeMap, config);
}
+ private void handleMetadataSessionEvent(SessionEvent e) {
+ LOG.info("Received metadata service session event: {}", e);
+ if (e == SessionEvent.SessionLost
+ && config.getZookeeperSessionExpiredPolicy() ==
MetadataSessionExpiredPolicy.shutdown) {
+ LOG.warn("The session with metdata service was lost. Shutting
down.");
Review comment:
typo: metdata
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
##########
@@ -329,7 +329,11 @@ public static void main(String[] args) throws Exception {
BrokerStarter starter = new BrokerStarter(args);
Runtime.getRuntime().addShutdownHook(
new Thread(() -> {
Review comment:
what about giving a name to the thread, now that we are touching this
code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
