eolivelli commented on issue #12087: URL: https://github.com/apache/pulsar/issues/12087#issuecomment-925839190
from your example it looks like newSingleMessage is useful to extract a Message from a batch. how can you apply this to KOP ? do we need to refactor ConsumerImpl ? I though that this would be a simpler change, but in fact you have to deal with the fact that the Converter may decide to split the single message into multiple messages. I am not sure if we should have a `DefaultConverter`. if you really need it please make it more evident in the PIP description. I am not sure about the overhead we are introducing with the DefaultConverter. isn't it possible to do like: if (I have a converter) .... run the new code else .... run the optimized existing code without the the Converter ? we will avoid many allocations and using many CPU cycles cc @merlimat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
