GPrabhudas commented on a change in pull request #612:
URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r714900932



##########
File path: pulsar/consumer_partition.go
##########
@@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response 
*pb.CommandMessage, header
                return err
        }
 
-       uncompressedHeadersAndPayload, err := pc.Decompress(msgMeta, 
headersAndPayload)
+       decryptedPayload, err := 
pc.decryptor.Decrypt(headersAndPayload.ReadableSlice(), pbMsgID, msgMeta)
+       messages := make([]*message, 0)
+
+       // error decrypting the payload
+       if err != nil {
+               pc.log.Error(err)
+               switch pc.decryptor.CryptoFailureAction() {
+               case crypto.ConsumerCryptoFailureActionFail:
+                       pc.log.Errorf("consuming message failed due to 
decryption err :%v", err)

Review comment:
       thanks @cckellogg 
   
   I don't think CI is failing due to last commit.
   
   I see most of the open PR's are failing with the same issue as below.
   
   `TestNamespaceTopicsNamespaceDoesNotExit (56.25s)
       client_impl_test.go:387: 
                Error Trace:    client_impl_test.go:387
                Error:          Expected nil, but got: 
&errors.errorString{s:"server error: AuthorizationError: Exception occurred 
while trying to authorize GetTopicsOfNamespace"}
                Test:           TestNamespaceTopicsNamespaceDoesNotExit`
   
   And last commit do not have any changes that effects `client_impl.go`. More 
likely this has something to do with broker config that CI uses for running 
test cases.
   
   please let me know If I'm wrong here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to