metahys commented on a change in pull request #12118:
URL: https://github.com/apache/pulsar/pull/12118#discussion_r715452313
##########
File path: pulsar-client-cpp/tests/ConsumerConfigurationTest.cc
##########
@@ -28,11 +28,19 @@ DECLARE_LOG_OBJECT()
using namespace pulsar;
+class DummyEventListener : public ConsumerEventListener {
+ public:
+ virtual void becomeActive(Consumer consumer, int partitionId) override {}
Review comment:
I have added unit tests in `ConsumerTest`. And I renamed "become" to
"became" to make it consistent with java client. The call to `registerConsumer`
is moved from `handleCreateConsumer` to `connectionOpened`, so that we can
handle commands such as `ACTIVE_CONSUMER_CHANGE` properly.
@merlimat Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
