RobertIndie opened a new pull request #12171:
URL: https://github.com/apache/pulsar/pull/12171
### Motivation
Currently, when we send chunked messages, the producer returns the
message-id of the last chunk. This can cause some problems. For example, when
we use this message-id to seek, it will cause the consumer to consume from the
position of the last chunk, and the consumer will mistakenly think that the
previous chunks are lost and choose to skip the current message. If we use the
inclusive seek, the consumer may skip the first message, which brings the wrong
behavior.
Here is the simple code used to demonstrate the problem.
```java
var msgId = producer.send(...); // eg. return 0:1:-1
var otherMsg = producer.send(...); // return 0:2:-1
consumer.seek(msgId); // inclusive seek
var receiveMsgId = consumer.receive().getMessageId(); // it may skip the
first message and return like 0:2:-1
Assert.assertEquals(msgId, receiveMsgId); // fail
```
### Modifications
When the producer sends a chunked message, the message-id of the first chunk
is stored temporarily in the producer until all chunks have been sent, and then
it is returned to the user after all chunks has been sent successfully.
### Verifying this change
This PR is still working in progress, still need to add some tests.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (yes) It affects the behavior of sending chunked
messages.
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [x] no-need-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
