yuruguo commented on a change in pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#discussion_r715982722
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
##########
@@ -244,10 +242,19 @@ public void runPerformanceTest(long messages, long limit,
int numOfTopic, int si
executor.submit(() -> {
try {
RateLimiter rateLimiter = RateLimiter.create(limit);
+ long startTime = System.nanoTime();
+ long testEndTime = startTime + (long) (testTime * 1e9);
// Send messages on all topics/producers
long totalSent = 0;
while (true) {
for (String topic : producersMap.keySet()) {
+ if (testTime > 0 && System.nanoTime() > testEndTime) {
+ log.info("------------- DONE (reached the maximum
duration: [{} seconds] of production) --------------", testTime);
+ printAggregatedStats();
+ Thread.sleep(5000);
Review comment:
It is no problem to exit directly without sleeping.
##########
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
##########
@@ -244,10 +242,19 @@ public void runPerformanceTest(long messages, long limit,
int numOfTopic, int si
executor.submit(() -> {
try {
RateLimiter rateLimiter = RateLimiter.create(limit);
+ long startTime = System.nanoTime();
+ long testEndTime = startTime + (long) (testTime * 1e9);
// Send messages on all topics/producers
long totalSent = 0;
while (true) {
for (String topic : producersMap.keySet()) {
+ if (testTime > 0 && System.nanoTime() > testEndTime) {
+ log.info("------------- DONE (reached the maximum
duration: [{} seconds] of production) --------------", testTime);
Review comment:
Sorry, I understand that there is only one worker thread in the thread
pool processing data (maybe we can add `--num-test-threads` to support
multi-threading like `PerformanceProducer`), in this case, it will only be
printed once. Am I correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
