liangyuanpeng commented on a change in pull request #12047:
URL: https://github.com/apache/pulsar/pull/12047#discussion_r716136591
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -610,6 +610,11 @@ public void start() throws PulsarServerException {
throw new
IllegalArgumentException("brokerServicePort/brokerServicePortTls must be
present");
}
+ if (config.isTlsEnabled()
+ && (!config.getWebServicePortTls().isPresent() ||
!config.getBrokerServicePortTls().isPresent())){
+ throw new
IllegalArgumentException("webServicePortTls/brokerServicePortTls must be
present");
Review comment:
It is better to be consistent with the current state of the project,
same of `brokerServicePort/brokerServicePortTls must be present`It is better to
be consistent with the current state of the project, same of
`brokerServicePort/brokerServicePortTls must be present`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
