lordcheng10 edited a comment on pull request #12195: URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927322511
Thank you for your attention！ For similar producer close logic, we can refer to Kafka's processing: https://cwiki.apache.org/confluence/display/KAFKA/KIP-8+-+Add+a+flush+method+to+the+producer+API It may be more reasonable for the producer to flush during close. When closing, sending the unsent data to the server is a common demand of users. No user would be more willing to discard the data in the buffer. Of course, we can also provide a close method with a timeout to satisfy some users who do not want the close method to take too much time. @BewareMyPower @eolivelli @merlimat @sijie @hangc0276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
