michaeljmarshall opened a new pull request #12229:
URL: https://github.com/apache/pulsar/pull/12229


   ### Motivation
   
   The Java client currently increments a stat with the size of pending 
messages queue. This would make sense, except for the fact that the queue is 
cleared right before getting the size. Further, the stat in question is 
incremented within the `failPendingMessages` method, which is called right 
before the removed line.
   
   ### Modifications
   
   * Remove the line `stats.incrementSendFailed();`, since it is unnecessary.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This change does not affect any public behavior.
   
   ### Documentation
   
   No docs need updating.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to