michaeljmarshall commented on pull request #12123:
URL: https://github.com/apache/pulsar/pull/12123#issuecomment-929651688


   @zymap - If I understand this class correctly, the new `state` variable will 
never be able to interrupt an infinite while loop because both `closeAsync` and 
the while loop are run on the class's single threaded executor. If the while 
loop is in an infinite loop, the `closeAsync` runnable will never get run. I 
tried to address your comment here: 
https://github.com/apache/pulsar/pull/12123#discussion_r716969863. Let me know 
if you think my understanding makes sense or is incorrect in some way. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to