Anonymitaet commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r718082528
##########
File path: site2/docs/reference-configuration.md
##########
@@ -352,6 +352,8 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| managedLedgerInfoCompressionType | Compression type of managed ledger
information. <br><br>Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and
`SNAPPY`). <br><br>If this value is `NONE` or invalid, the `managedLedgerInfo`
is not compressed. <br><br>**Note** that after enabling this configuration, if
you want to degrade a broker, you need to change the value to `NONE` and make
sure all ledger metadata is saved without compression. | None |
| additionalServlets | Additional servlet name. <br><br>If you have multiple
additional servlets, separate them by commas. <br><br>For example,
additionalServlet_1, additionalServlet_2 | N/A |
| additionalServletDirectory | Location of broker additional servlet NAR
directory | ./brokerAdditionalServlet |
+| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. if enabled, 1.bookie-ensemble will firstly try choosing from bookies
belongs to namespace's affinity group, if bookies are not enough, then the rest
bookies will be chosen. 2.if namespace has no affinity group, bookie-ensemble
will only be chosen from bookies belong to no region, if bookies are not
enough, BKNotEnoughBookiesException will be throwed.| false |
Review comment:
```suggestion
| strictBookieAffinityEnabled | Enable or disable the strict bookie
isolation strategy. If enabled, <br /> - `bookie-ensemble` first tries to
choose bookies that belong to a namespace's affinity group. If the number of
bookies is not enough, then the rest bookies are chosen. <br /> - If namespace
has no affinity group, `bookie-ensemble` only chooses bookies that belong to no
region. If the number of bookies is not enough, `BKNotEnoughBookiesException`
is thrown.| false |
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -352,6 +352,8 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| managedLedgerInfoCompressionType | Compression type of managed ledger
information. <br><br>Available options are `NONE`, `LZ4`, `ZLIB`, `ZSTD`, and
`SNAPPY`). <br><br>If this value is `NONE` or invalid, the `managedLedgerInfo`
is not compressed. <br><br>**Note** that after enabling this configuration, if
you want to degrade a broker, you need to change the value to `NONE` and make
sure all ledger metadata is saved without compression. | None |
| additionalServlets | Additional servlet name. <br><br>If you have multiple
additional servlets, separate them by commas. <br><br>For example,
additionalServlet_1, additionalServlet_2 | N/A |
| additionalServletDirectory | Location of broker additional servlet NAR
directory | ./brokerAdditionalServlet |
+| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. if enabled, 1.bookie-ensemble will firstly try choosing from bookies
belongs to namespace's affinity group, if bookies are not enough, then the rest
bookies will be chosen. 2.if namespace has no affinity group, bookie-ensemble
will only be chosen from bookies belong to no region, if bookies are not
enough, BKNotEnoughBookiesException will be throwed.| false |
Review comment:
Do you intend to mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
