merlimat commented on pull request #7499: URL: https://github.com/apache/pulsar/pull/7499#issuecomment-930517633
@rdhabalia Have tried with #7406 which is already in 2.8? I still think we shouldn't add contended counters. We have validated that previous OOMs are not happening anymore in 2.8. The changes in #7406 can still be improved to use token bucket to distribute capacity across the threads, in which case the contention will be amortized away. Although, in practice, I haven't seen the skew across threads being a significant problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
