EronWright commented on pull request #8019:
URL: https://github.com/apache/pulsar/pull/8019#issuecomment-930584223


   @zymap I just noticed this fix, and do you recall why you fixed it in this 
way.  The true issue looks to me that the `Authentication` interface has a 
`start` method and a `getAuthData` method but that the `PulsarProxy` calls 
`getAuthData` before calling `start`.  The OAuth2 implementation assumes that 
`start` will be called first.  This PR avoids taking that assumption, but is it 
not a correct assumption to make?
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to