LeBW commented on a change in pull request #12215:
URL: https://github.com/apache/pulsar/pull/12215#discussion_r719299435
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -632,25 +632,29 @@ protected void
internalDeletePartitionedTopic(AsyncResponse asyncResponse, boole
return;
}
}
+ // Only tries to delete the authentication policies for
partitioned topic when all its partitions are
+ // successfully deleted
+
pulsar().getBrokerService().deleteTopicAuthenticationWithRetry(topicName.toString());
Review comment:
> Maybe we need to ensure all resources of the topic all clean up, then
delete the topic from the ManagedLedger? It seems that the result of the method
`deleteTopicAuthenticationWithRetry` didn't affect the delete topic operation
result.
For partitioned topic, the deletion of ManagedLedger is in
`pulsar().getAdminClient().topics().deleteAsync(topicNamePartition.toString(),
force)`, which is before the deletion of metadata and authentication policies.
Do you mean that we should modify the logic here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
