codelipenghui commented on a change in pull request #10478:
URL: https://github.com/apache/pulsar/pull/10478#discussion_r719464344
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ReadOnlyCursor.java
##########
@@ -46,10 +46,11 @@
* @param callback callback object
* @param ctx opaque context
* @param maxPosition max position can read
+ * @param epoch epoch of this read
* @see #readEntries(int)
*/
void asyncReadEntries(int numberOfEntriesToRead, ReadEntriesCallback
callback,
- Object ctx, PositionImpl maxPosition);
+ Object ctx, PositionImpl maxPosition, long epoch);
Review comment:
Can we move the epoch into the ctx? I think it should be a context or a
carrier, if want to add more ctx in the future, we do not want to add more
params, maybe we can try to create a ReadEntryContext(with recycle), the
consumer ref, and the epoch should ship to the ReadEntryContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
